-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bootc to Bluefin #1285
Conversation
@m2Giles feel free to work from this PR to get this merged into Bluefin. |
With the iso justfiles merged, we should be able to iterate this quickly. Will look at this later. |
Moving the bootupctl command before the initramfs generation worked. |
fix: iso permissions for cleanup
Note: using testing branch for the better brew install as well. Bootc is waiting on an update to the GitHub action |
Probably should of just rebased to before the brew stuff. But it's all removed. This merge is currently waiting on a pinned release of the container build installer action. |
then I rebased to |
I just realized I've only tested 40 images since we added the bootc.sh. Need to make sure it doesn't negatively effect 39 images. |
Ok so should I add gdisk in a separate PR? |
I think that is for the install to disk option of bootc. Kinda like the coreOS installer command |
Do we have a slimmed down testing image for things like this (https://github.com/rust-vmm/rust-vmm-container/blob/main/Dockerfile)?) I am literally working on bootc testing because virt-vmm supposedly supports natively connecting to guest VMs, and supports booting directly from images. I guess just the fedora-bootc:41 ... maybe with nvidia because intercepts some things but I was hoping something lightweight. Their repo is like all over the place, I'm guessing this (https://gitlab.com/fedora/bootc/base-images-experimental/-/blob/main/Containerfile?ref_type=heads) but the containerfile is hardcoded to 40? Ignore my virt-vmm is there anything you're using or I'm missing to do some smoke tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM!
And sorry if it seemed like I was nit-picking
Nope. This was weird where I had another branch where I was doing changes as well and some cleanup was missing. This is why we review! |
Upstream Issue
ublue-os/main#572
Purpose
We would like to test adding bootc to bluefin before adding it to main. Ideally, we should be able to test it here and then implement in main.
Things that need to change before merging